Quick Search:

View detailed chart Line History

line history graph

View Mode

Logical Physical

Show Arbitrary Diff

From to

Supports revisions and tags.

Watches and RSS

History

trunk 4744 347

latest revision download trunk

4744 annotated / raw | Diffs: previous, other | Lines: 363 ( +11, -3 )

Created: 2008-12-09 17:14:43 -0800 (29 days ago) | Author: bothner | Changeset: 4744

Undo changeset 4705, which reverted changeset 4664, bringing back:

Change ArraySequence to use a buffer-gap.  Perhaps modification and
concatenation "in-place" if the 'shared' flag is false.
This implements JFXC-2336 "implement shared-unshared sequence optimization".

Branch point for: franca

Tags: m8

4705 annotated / raw | Diffs: previous, other | Lines: 355 ( +3, -11 )

Created: 2008-11-30 21:21:30 -0800 (37 days ago) | Author: briangoetz | Changeset: 4705

Back out changeset 4664

Tags: trunk-checkpoint

4664 annotated / raw | Diffs: previous, other | Lines: 363 ( +11, -3 )

Created: 2008-11-19 16:28:58 -0800 (49 days ago) | Author: bothner | Changeset: 4664

Change ArraySequence to use a buffer-gap.  Perhaps modification and
concatenation "in-place" if the 'shared' flag is false.
This implements JFXC-2336 "implement shared-unshared sequence optimization".

4645 annotated / raw | Diffs: previous, other | Lines: 355 ( +18, -15 )

Created: 2008-11-16 13:35:11 -0800 (52 days ago) | Author: bothner | Changeset: 4645

Change 'insert before' and 'insert after' so that out-of-range index
is treated as inserting at the beginning or end of the target.
This fixes JFXC-2386 "incorrect implementation of out-of-range insert before
and insert after".

4637 annotated / raw | Diffs: previous, other | Lines: 352 ( +4, -1 )

Created: 2008-11-14 13:18:51 -0800 (54 days ago) | Author: briangoetz | Changeset: 4637

JFXC-2381 - Don't create a SliceReplacementSequence when we're replacing the entire thing; just use the newValues sequence as the new value.

4496 annotated / raw | Diffs: previous, other | Lines: 349 ( +2, -2 )

Created: 2008-10-24 00:43:33 -0700 (2 months 14 days ago) | Author: michael_heinrichs | Changeset: 4496

Update copyright-headers (JFXC-2148).

Branch point for: perf-sandbox

4282 annotated / raw | Diffs: previous, other | Lines: 349 ( +2, -11 )

Created: 2008-10-03 04:39:59 -0700 (3 months 4 days ago) | Author: michael_heinrichs | Changeset: 4282

Copied to: branches/m7-release/trunk/src/share/classes/com/sun/javafx/runtime/sequence/SequenceMutator.java 4321

Some minor improvements:
- SubSequence inherits from DerivedSequence
- Moved shouldFlatten() to Sequences
- Flattening filtered sequence, if it meets criteria

Branch point for: m7-release tag:milestone-7

Tags: milestone-7

4276 annotated / raw | Diffs: previous, other | Lines: 358 ( +13, -16 )

Created: 2008-10-02 22:53:36 -0700 (3 months 4 days ago) | Author: michael_heinrichs | Changeset: 4276

Introducing new sequence-type ElementReplacementSequence. It is used when a single element is inserted in a sequence or a gap of size > 1 is replaced with a single element.

Some minor improvements of SliceReplacementSequence.

4239 annotated / raw | Diffs: previous, other | Lines: 361 ( +2, -2 )

Created: 2008-09-30 12:59:45 -0700 (3 months 7 days ago) | Author: briangoetz | Changeset: 4239

Generics cleanup in SequenceMutator / SliceReplacementSequence.

4233 annotated / raw | Diffs: previous, other | Lines: 361 ( +0, -0 )

Created: 2008-09-30 02:15:53 -0700 (3 months 7 days ago) | Author: michael_heinrichs | Changeset: 4233

Reverting last change until regression is fixed.

4231 annotated / raw | Diffs: previous, other | Lines: 361 ( +2, -7 )

Created: 2008-09-30 01:03:26 -0700 (3 months 7 days ago) | Author: michael_heinrichs | Changeset: 4231

Added SliceReplacementSequence which is used for replaceSlice- and delete-operations. The implementation reduces memory usage and increases performance. ReplaceSlice-operations become up to twice as fast, delete-operations become 5x - 80x faster (depending mostly on sequence-size) than the original implementation.

4217 annotated / raw | Diffs: previous, other | Lines: 366 ( +2, -2 )

Created: 2008-09-29 02:48:12 -0700 (3 months 8 days ago) | Author: michael_heinrichs | Changeset: 4217

Remove unecessary checkForNull()-calls in flattening process (JFXC-1966). The call is unecessary, because the sequence which is flattened cannot contain nulls.

4110 annotated / raw | Diffs: previous, other | Lines: 366 ( +4, -5 )

Created: 2008-09-17 11:14:26 -0700 (3 months 20 days ago) | Author: briangoetz | Changeset: 4110

JFXC-1981 (optimize away equality comparison when there are no triggers); JFXC-1982 (eliminate reification of sequences.)  Sequence and Object *locations* are still reified; we may be able to eliminate those later, though they are currently needed for bidirectional binding.  Clean up TypeInfo classes; merge TypeInfos into TypeInfo, make members of TypeInfo final fields instead of methods.

4100 annotated / raw | Diffs: previous, other | Lines: 367 ( +6, -5 )

Created: 2008-09-16 20:44:26 -0700 (3 months 21 days ago) | Author: rfield | Changeset: 4100

Partial JFXC-1982 : Eliminate reification of sequence element types
Use new TypeInfo instead of Class in the construction of sequences.
TypeInfo is then used to create default values and empty sequences.
Regression test added that checks defaults.

Runtime changes by Brian.
Compiler changes by Robert.

Also regression test for 849 changed to not depend on the implementing class name.

4045 annotated / raw | Diffs: previous, other | Lines: 366 ( +1, -1 )

Created: 2008-09-12 04:26:59 -0700 (3 months 25 days ago) | Author: michael_heinrichs | Changeset: 4045

Added toArray()-methods for ReplacementSequence and SubSequence.
Fixed bug in SequenceMutator.

4041 annotated / raw | Diffs: previous, other | Lines: 366 ( +3, -1 )

Created: 2008-09-11 14:37:17 -0700 (3 months 26 days ago) | Author: briangoetz | Changeset: 4041

Use integer log instead of floating point log to calculate flattening threshold.

2786 annotated / raw | Diffs: previous, other | Lines: 364 ( +1, -3 )

Created: 2008-05-28 15:43:32 -0700 (7 months ago) | Author: tball | Changeset: 2786

updated license headers

Branch point for: technology-preview-1 uicontrols

Tags: 2008-06-02 2008-06-09 2008-06-16 2008-06-23 2008-06-30 2008-07-07 milestone-6

2745 annotated / raw | Diffs: previous, other | Lines: 366 ( +4, -4 )

Created: 2008-05-22 12:18:26 -0700 (7 months ago) | Author: briangoetz | Changeset: 2745

Simplify core Sequence (not SequenceLocation) interface to eliminate mutative methods; move mutative helpers to Sequences.

Tags: 2008-05-26

2652 annotated / raw | Diffs: previous, other | Lines: 366 ( +3, -6 )

Created: 2008-04-25 11:57:42 -0700 (8 months ago) | Author: briangoetz | Changeset: 2652

Clean up and fix test failure from r2650 checkin.

Tags: 2008-04-28 2008-05-05 2008-05-12 2008-05-19

2464 annotated / raw | Diffs: previous, other | Lines: 369 ( +3, -0 )

Created: 2008-04-07 16:57:29 -0700 (9 months ago) | Author: briangoetz | Changeset: 2464

Optimization: more aggressively flatten sequences; based on Chris' observation that CompositeSequence.get() is on the profile for JavaFXBalls.  No longer is.

Branch point for: javaone-2008 tag:M2 tag:M3

Tags: M3 2008-04-14 2008-04-21

2456 annotated / raw | Diffs: previous, other | Lines: 366 ( +13, -1 )

Created: 2008-04-07 14:07:02 -0700 (9 months ago) | Author: briangoetz | Changeset: 2456

Complete JFXC-885; fire trigger for default value on sequence-valued attributes.  

Tests queries01 and inittrigger2 are failing, but I suspect that is because the tests were testing old behavior; passing to Steve for verification.  

Misc cleanups in sequence code, notably unrolling ill-conceived SequenceHelper class.

2310 annotated / raw | Diffs: previous, other | Lines: 354 ( +8, -4 )

Created: 2008-03-26 15:17:43 -0700 (9 months ago) | Author: PeterKessler | Changeset: 2310

JFXC-928: Performance bug in the compiler runtime, specifically ReplacementSequence

Added Sequence.shouldFlatten(), and default implementation in AbstractSequence.  
Used it from SequenceMutator.replaceSlice(.... T newValue).

Also, a small performance tweak to AbstractSequence.flatten(): start with a SequenceBuilder of the right size, and use the SequenceBuilder.add(Sequence<T>) method instead of adding one element at a time.

Tags: 2008-03-31 2008-04-07

1634 annotated / raw | Diffs: previous, other | Lines: 350 ( +2, -0 )

Created: 2008-02-10 12:44:01 -0800 (10 months ago) | Author: briangoetz | Changeset: 1634

JFXC-621 -- runtime should not allow seequence elements to be set to null.

Branch point for: tag:2008-02-25 tag:weekly-2008-02-11

Tags: weekly-2008-02-11 weekly-2008-02-18 weekly-2008-02-25 2008-02-25 M2 2008-03-03 2008-03-10 2008-03-17 2008-03-24

1572 annotated / raw | Diffs: previous, other | Lines: 348 ( +2, -2 )

Created: 2008-02-03 15:47:19 -0800 (11 months ago) | Author: rfield | Changeset: 1572

Fix JFXC-627 : implement inserting before/after some element
Fix JFXC-570 :  Sequence syntax for M2
(as 627 is the last subtask)
Feature test is extended to cover the new functionality.
Also, clean up of identifier vs name in grammar; and more user friendly tree walker errors.
Description to dev to follow.

Branch point for: brian-initialization-overhaul tag:weekly-2008-02-04

Tags: weekly-2008-02-04

1502 annotated / raw | Diffs: previous, other | Lines: 348 ( +2, -0 )

Created: 2008-01-24 19:21:37 -0800 (11 months ago) | Author: briangoetz | Changeset: 1502

Belt-and-suspenders for previous fix.

1501 annotated / raw | Diffs: previous, other | Lines: 346 ( +3, -3 )

Created: 2008-01-24 19:15:59 -0800 (11 months ago) | Author: briangoetz | Changeset: 1501

Fix for NPE's encountered by Jim and Per in porting runtime to unified triggers.

1480 annotated / raw | Diffs: previous, other | Lines: 346 ( +9, -4 )

Created: 2008-01-22 20:39:10 -0800 (11 months ago) | Author: briangoetz | Changeset: 1480

JFXC-200; make Sequence classes more robust to null arguments.

1280 annotated / raw | Diffs: previous, other | Lines: 341 ( +166, -170 )

Created: 2007-12-28 18:56:09 -0800 (12 months ago) | Author: briangoetz | Changeset: 1280

Copied to: branches/antlr-update/trunk/src/share/classes/com/sun/javafx/runtime/sequence/SequenceMutator.java 1391

Lay groundwork for bound sequences by using 3-place replace operation and trigger internally.  Simplify BoundCompositeSequence; implement BoundReverseSequence.  More tests, misc test cleanup.

Branch point for: reprise

Tags: weekly-2008-01-14 weekly-2008-04-21

1273 annotated / raw | Diffs: previous, other | Lines: 345 ( +10, -19 )

Created: 2007-12-27 14:24:59 -0800 (12 months ago) | Author: briangoetz | Changeset: 1273

JFXC-334 -- Ignore out-of-bound sequence insertions, as we do with deletion, instead of treating them as at-bounds insertions.

1003 annotated / raw | Diffs: previous, other | Lines: 354 ( +1, -9 )

Created: 2007-12-01 17:43:46 -0800 (13 months ago) | Author: briangoetz | Changeset: 1003

Copied to: branches/new-hash-syntax/trunk/src/share/classes/com/sun/javafx/runtime/sequence/SequenceMutator.java 1217

Optimize sequence element replacement; instead of concatenating subsequences, use the new ReplacementSequence class.

Branch point for: new-hash-syntax

Tags: M1

1001 annotated / raw | Diffs: previous, other | Lines: 362 ( +2, -2 )

Created: 2007-12-01 17:27:06 -0800 (13 months ago) | Author: briangoetz | Changeset: 1001

More unchecked cast cleanup

1000 annotated / raw | Diffs: previous, other | Lines: 362 ( +35, -35 )

Created: 2007-12-01 17:11:35 -0800 (13 months ago) | Author: briangoetz | Changeset: 1000

Move sequence covariance into runtime while avoiding <? extends T> contageon.  Covariance is now supported in the various SequenceLocation classes, by reifying sequence location component types and using an optimized runtime upcast which is a no-op if no covariance is being employed.  The only places where the <? extends T> is needed is in whole-sequence replacement, such as SequenceVar.set(), SequenceBindingExpression.get(), and SequenceVar.make().  Everywhere else can be just <T>.  

Create utility routines to launder some unchecked casts, especially generic array creation.

940 annotated / raw | Diffs: previous, other | Lines: 362 ( +3, -2 )

Created: 2007-11-27 14:03:43 -0800 (13 months ago) | Author: briangoetz | Changeset: 940

Partial fix for JFXC-273.  Call delete triggers in reverse order.

886 annotated / raw | Diffs: previous, other | Lines: 361 ( +40, -40 )

Created: 2007-11-24 22:38:07 -0800 (13 months ago) | Author: bothner | Changeset: 886

Change Sequence<T> to Sequence<? extends T> for proper covariance.
This implied a number of changes.  Beyond changing signatures, I also
changed insertXxx and deleteXxx methods in Sequence to be static
methods in Sequences, since otherwise javac didn't infer correct types.
(This leads to some redundancy between insertxxx and concatenate methods.)

Note that SequenceVar is not covariant.

433 annotated / raw | Diffs: previous, other | Lines: 361 ( +25, -0 )

Created: 2007-10-10 10:42:57 -0700 (14 months ago) | Author: briangoetz | Changeset: 433

JFXC-62: add copyright notices everywhere; correct dates on existing copyright notices.

347 new annotated / raw | Lines: 336 ( +336, -0 )

Created: 2007-09-28 16:09:51 -0700 (15 months ago) | Author: briangoetz | Changeset: 347

Back out SequenceLocation interface changes; extend SequenceChangeListener to report index of changed; update and extend tests.

Crucible: Open Source License registered to Atlassian.
Atlassian Crucible, painless code review. (Version:1.6.1 Build:build-r20568 2008-09-30) - Administration - Page generated 2009-01-07 20:04 -0800