Quick Search:

View detailed chart Line History

line history graph

View Mode

Logical Physical

Show Arbitrary Diff

From to

Supports revisions and tags.

Watches and RSS

History

trunk 4778 865

latest revision download trunk

4778 annotated / raw | Diffs: previous, other | Lines: 279 ( +5, -1 )

Created: 2008-12-17 20:09:15 -0800 (20 days ago) | Author: rfield | Changeset: 4778

Fixed JFXC-2510 : Translation: conversion between bound numeric sequences
use new runtime conversion.
factor-out common code with unbound case.

Enable test for JFXC-2492   Runtime: conversion between bound numeric sequences
since it is now being used.

Branch point for: franca

Tags: m8

4768 annotated / raw | Diffs: previous, other | Lines: 275 ( +4, -0 )

Created: 2008-12-16 09:40:14 -0800 (22 days ago) | Author: bothner | Changeset: 4768

Implementation for JFXC-942 "Compiler should emit warning when source
instantiates a thread or calls Thread.start()".

4744 annotated / raw | Diffs: previous, other | Lines: 271 ( +4, -0 )

Created: 2008-12-09 17:14:43 -0800 (29 days ago) | Author: bothner | Changeset: 4744

Undo changeset 4705, which reverted changeset 4664, bringing back:

Change ArraySequence to use a buffer-gap.  Perhaps modification and
concatenation "in-place" if the 'shared' flag is false.
This implements JFXC-2336 "implement shared-unshared sequence optimization".

4713 annotated / raw | Diffs: previous, other | Lines: 267 ( +6, -2 )

Created: 2008-12-02 17:20:35 -0800 (36 days ago) | Author: rfield | Changeset: 4713

Progress JFXC-2439 : Common numeric type definitions
Progress JFXC-2438 : full numeric type Locations

Tags: trunk-checkpoint

4712 annotated / raw | Diffs: previous, other | Lines: 263 ( +2, -0 )

Created: 2008-12-02 15:03:22 -0800 (36 days ago) | Author: rfield | Changeset: 4712

Fixed JFXC-2433 : Eliminate class literals
Consistently use TypeInfo (instead of mixture of Class<T> and TypeInfo) for identifying type in sequences.  
This makes the code more mobile friendly.
Runtime changes by Brian.
Compiler support by Robert
Existing sequence tests cover this space.

Fixed JFXC-1955 : Compiler error while creating a sequence of functions in bind-context
currently failing test moved to regress.

Fixed JFXC-2402 : declaring sequence of functions crashes compiler
new regress test

4705 annotated / raw | Diffs: previous, other | Lines: 261 ( +0, -4 )

Created: 2008-11-30 21:21:30 -0800 (37 days ago) | Author: briangoetz | Changeset: 4705

Back out changeset 4664

4664 annotated / raw | Diffs: previous, other | Lines: 265 ( +4, -0 )

Created: 2008-11-19 16:28:58 -0800 (49 days ago) | Author: bothner | Changeset: 4664

Change ArraySequence to use a buffer-gap.  Perhaps modification and
concatenation "in-place" if the 'shared' flag is false.
This implements JFXC-2336 "implement shared-unshared sequence optimization".

4496 annotated / raw | Diffs: previous, other | Lines: 261 ( +2, -2 )

Created: 2008-10-24 00:43:33 -0700 (2 months 14 days ago) | Author: michael_heinrichs | Changeset: 4496

Update copyright-headers (JFXC-2148).

Branch point for: perf-sandbox

4362 annotated / raw | Diffs: previous, other | Lines: 261 ( +9, -9 )

Created: 2008-10-08 16:14:25 -0700 (2 months 30 days ago) | Author: bothner | Changeset: 4362

Replace Name.fromString(names, "foo") by names.fromString("foo").
Not only is the latter simpler, the former no longer works with
the current javac sources.

4306 annotated / raw | Diffs: previous, other | Lines: 261 ( +3, -0 )

Created: 2008-10-04 11:46:58 -0700 (3 months 3 days ago) | Author: rfield | Changeset: 4306

Copied to: branches/m7-release/trunk/src/share/classes/com/sun/tools/javafx/comp/JavafxDefs.java 4321

Fixed JFXC-2135 : javafx.lang.Builtins change breaks FX.isInitialized and GUI runtime -- compiler change needed
Tested by broadening the 1249 test.

Fixed JFXC-2133 : Restore elision for classes with init {} blocks
Introduce mechanism parallel to Location.needsDefault() via boolean fields on object for elided instance vars.
With regression test.

Partial JFXC-2103 : Elide object literal inited and public-init initable member vars
Object literal inited instance variables are now elided.
But if publicly visible variables are elided, the hardcoded GUI cide break.

Branch point for: m7-release tag:milestone-7

Tags: milestone-7

4232 annotated / raw | Diffs: previous, other | Lines: 258 ( +2, -0 )

Created: 2008-09-30 01:46:40 -0700 (3 months 7 days ago) | Author: rfield | Changeset: 4232

Progress JFXC-2025 : Elide unbound script-private member vars
Proper inter-script handling of setter.
Handling of special Duration TYPE_INFO variable.
Assignment to raw statics.

4160 annotated / raw | Diffs: previous, other | Lines: 256 ( +4, -0 )

Created: 2008-09-20 17:18:00 -0700 (3 months 17 days ago) | Author: rfield | Changeset: 4160

Progress JFXC-2025 : Elide unbound script-private member vars
Generate setter methods for non-Location instance vars.

4110 annotated / raw | Diffs: previous, other | Lines: 252 ( +1, -1 )

Created: 2008-09-17 11:14:26 -0700 (3 months 20 days ago) | Author: briangoetz | Changeset: 4110

JFXC-1981 (optimize away equality comparison when there are no triggers); JFXC-1982 (eliminate reification of sequences.)  Sequence and Object *locations* are still reified; we may be able to eliminate those later, though they are currently needed for bidirectional binding.  Clean up TypeInfo classes; merge TypeInfos into TypeInfo, make members of TypeInfo final fields instead of methods.

4100 annotated / raw | Diffs: previous, other | Lines: 252 ( +3, -0 )

Created: 2008-09-16 20:44:26 -0700 (3 months 20 days ago) | Author: rfield | Changeset: 4100

Partial JFXC-1982 : Eliminate reification of sequence element types
Use new TypeInfo instead of Class in the construction of sequences.
TypeInfo is then used to create default values and empty sequences.
Regression test added that checks defaults.

Runtime changes by Brian.
Compiler changes by Robert.

Also regression test for 849 changed to not depend on the implementing class name.

4015 annotated / raw | Diffs: previous, other | Lines: 249 ( +1, -1 )

Created: 2008-09-09 19:21:36 -0700 (3 months 28 days ago) | Author: rfield | Changeset: 4015

Partial JFXC-1957 : Track and print optimization statistics
infrastructure and tie-ins

Tags: milestone-6

3966 annotated / raw | Diffs: previous, other | Lines: 249 ( +6, -0 )

Created: 2008-09-03 22:23:43 -0700 (4 months 3 days ago) | Author: rfield | Changeset: 3966

Fixed JFXC-1932 : Pre-user-default value of String and Duration instance var is null (which is invalid)
For example, the old value in the following used to be null:      var str = "Hello" on replace old { println("old={old}") }
With regression test.
Existing regression test expected values had incorrect assumption, this has been corrected.

Fixed JFXC-1929 : translation obscures isInitialized state
Use setDefault() instead of explicit default value so that the disrinction can be noted by the runtime.
Parent JFXC-1249 "Provide isInitialized() method for variables"  supplies the regression test -- not currently pasing awaiting other sub-tasks

3964 annotated / raw | Diffs: previous, other | Lines: 243 ( +3, -0 )

Created: 2008-09-03 18:35:53 -0700 (4 months 4 days ago) | Author: rfield | Changeset: 3964

Fixed JFXC-1926 : Statically import top-level functions in java.lang
Currently these functions are in java.lang.FX -- awaiting a final decision on placement.  
But it doesn't much matter, they are all statically imported so the class isn't of any consequence.

Fixed JFXC-1924 : println
Added print(Object)  and println(Object).
Because of JFXC-1926 (above) they are ready for use, no import needed:   println("hi")
With regression test.

Partial JFXC-1249 : Provide isInitialized() method for variables
Library function and the needed special processing during translation are in place.
It calls into AbstractVariable in the compiler runtime, but that isn't giving the right value yet, see JFXC-1929.
Also checks need to be added to assure only instance variable references are passed in.
Regression test added, but it is in currently-failing until the compiler runtime issue is fixed.

3878 annotated / raw | Diffs: previous, other | Lines: 240 ( +5, -5 )

Created: 2008-08-25 14:39:23 -0700 (4 months 13 days ago) | Author: rfield | Changeset: 3878

Fixed JFXC-1864 : Use arguments name specified in run(argsName : String[]) function
Fixed JFXC-1862 : 'var' declaration as last statement of function causes loop on execution (and other bad acts)
Fixed JFXC-1863 : Check for multiple run functions
Fixed JFXC-1776 : Check for malformed 'run()' function parameters
Fixed JFXC-1823 : back-end error on bound function with variable declaration as function value

3787 annotated / raw | Diffs: previous, other | Lines: 240 ( +3, -0 )

Created: 2008-08-17 15:19:41 -0700 (4 months 21 days ago) | Author: rfield | Changeset: 3787

Fixed JFXC-1266 : Proper functiioning of public, protected, and script-private for methods
Fixed JFXC-1267 : Public, script-private, and protected access for class variables
Fixed JFXC-1795 : Support 'package' modifier
Implement and enforce script-private (default) access (previously was some mixture of private, package, and public access).
Implement and enforce 'package' access (previous was same as public).  Not correctly implemented on script-level classes, but this has been broken out as a separate issue -- see JFXC-1800.
Attach access annotations to classes and read them (when they are members).
Update JavaFX source in compiler runtime and tests to have correct acces modifers.

Probable fix to JFXC-1703 : Disallow more than one of private, public, package in Attr
But no regression test yet

Some work on JFXC-728 : script-private class variables not hidden from subclasses

3749 annotated / raw | Diffs: previous, other | Lines: 237 ( +1, -1 )

Created: 2008-08-13 23:46:52 -0700 (4 months 24 days ago) | Author: rfield | Changeset: 3749

This just in, while I was finishing my last commit, the decision was made that the name for the script launch function should be 'run':

 function run() { ... }

This commit makes that change.

3748 annotated / raw | Diffs: previous, other | Lines: 237 ( +2, -0 )

Created: 2008-08-13 22:25:15 -0700 (4 months 24 days ago) | Author: rfield | Changeset: 3748

This commit, among many other things, implements the variable initialization mechanism detailed in the email thread --

 Problem: script-level variable initialization and script bodies

Including

 function main() { ... }

To declare the main-code executed on launch.

Fixed JFXC-1769 : script level var not initialized in time
Revamp script variable initialization
With regression test.

Fixed JFXC-1761 : initialize$() on script-level not executed
Initialization put in proper place now
With regression test.

Fixed JFXC-1646 : variable visibility issue
On replace no longer changes visibility
With regression test.

Fixed JFXC-1721 : Script.fx: 'var a = 0; Script.a' fails
Script-private class access now works.
With regression test.

Partial JFXC-1250 : Visibility modifiers
Accessibility modifiers now work consistently (if not yet completely implemented)
Positive regression test: things are, at least, as accessible as they should be.

Tests and demoes updated to new rules for main-code.

A new bug and a new case of an old bug are exposed by these changes -- as reflected in tests moved to currently-failing.

Two follow-on task still need to be implemented.

3136 annotated / raw | Diffs: previous, other | Lines: 235 ( +4, -0 )

Created: 2008-06-30 18:06:13 -0700 (6 months ago) | Author: zhiqun | Changeset: 3136

jfxc1066: KeyFrameLiteral support with simple Intepolatedvalues

example: at (1s) {
                x=>5 tween Interpolator.LINEAR;
                y=>7
           }

Branch point for: uicontrols

Tags: 2008-07-07

3120 annotated / raw | Diffs: previous, other | Lines: 231 ( +12, -0 )

Created: 2008-06-27 22:02:08 -0700 (6 months ago) | Author: bothner | Changeset: 3120

Partial access control re-write.

The class file reader now skip most synthetic fields and methods.
A new Inherited annotation is used to "de-select" generated
stub fields and methods for inherited methods and attributes,
so these can also be skipped by teh class file reader.
"Attribute" access annotations are now on fields, not methods.
The ClassSymbol for a source file and from a class-file are
now much closer.  Because of that, I was able to rid of some of
the separate handling between classes-from-source and
classes-from-classfiles.

Also, some minor optimization (use Name rather than String)
while I was at it.

This doesn't do name mangling of attributes, but the attributeName
method sets that up.

Also still to do is tweaking of the access modifiers as discussed
- i.e. module visibility, plus more testing.

Tags: 2008-06-30

2786 annotated / raw | Diffs: previous, other | Lines: 219 ( +1, -3 )

Created: 2008-05-28 15:43:32 -0700 (7 months ago) | Author: tball | Changeset: 2786

updated license headers

Branch point for: technology-preview-1

Tags: 2008-06-02 2008-06-09 2008-06-16 2008-06-23

2608 annotated / raw | Diffs: previous, other | Lines: 221 ( +2, -1 )

Created: 2008-04-18 16:07:10 -0700 (8 months ago) | Author: tball | Changeset: 2608

Moved main method name to public class.

Branch point for: javaone-2008

Tags: 2008-04-21 2008-04-28 2008-05-05 2008-05-12 2008-05-19 2008-05-26

2548 annotated / raw | Diffs: previous, other | Lines: 220 ( +3, -0 )

Created: 2008-04-11 14:05:31 -0700 (8 months ago) | Author: briangoetz | Changeset: 2548

Fix JFXC-1033 -- excessive binding updates.  Also fix related problem with F15 test.  Fix unrelated multiple-binding-update problem with bound-if and bound-select clauses.  Add java.lang to list of packages auto-imported by pretty-printer.

Tags: 2008-04-14

2543 annotated / raw | Diffs: previous, other | Lines: 217 ( +13, -4 )

Created: 2008-04-11 04:42:17 -0700 (8 months ago) | Author: michael_heinrichs | Changeset: 2543

Simplifying javadump by omitting package-names from imported packages/classes.
Simplifying javadamp by omitting names of standard-packages (JFXC-963).

2496 annotated / raw | Diffs: previous, other | Lines: 208 ( +0, -2 )

Created: 2008-04-08 20:25:04 -0700 (9 months ago) | Author: rfield | Changeset: 2496

Most of JFXC-868 : Remove the binding state out of JavafxToJava

2406 annotated / raw | Diffs: previous, other | Lines: 210 ( +1, -0 )

Created: 2008-04-05 10:24:11 -0700 (9 months ago) | Author: rfield | Changeset: 2406

Clean-up related the JFXC-865

Branch point for: tag:M2 tag:M3

Tags: 2008-04-07 M3

2401 annotated / raw | Diffs: previous, other | Lines: 209 ( +1, -1 )

Created: 2008-04-04 22:02:10 -0700 (9 months ago) | Author: rfield | Changeset: 2401

Fixed JFXC-784 : Binding Overhaul
Fixed JFXC-865 : Binding Overhaul: only generate bound function version when 'bound'
Fixed JFXC-863 : Binding Overhaul: JavafxMethodSymbol has isBound()
Fixed JFXC-501 : Binding Overhaul: Bound sequence updates
Fixed JFXC-691 : Problem with function local variables when bound

Correct semantics of function binding now enabled.  
Removing the bogus re-execute the whole function semantics is the last piece needed to complete the Binding Overhaul.
Flicking the switch is possible thanks to Brian's fixes to the update semantics in the compiler runtime.

javafx.ui version of JavaFXPad now works with this enabled.
As Chris has reported Reprise demos work with it enabled.
javafx.ui version of StudioMoto comes up, though the bottom panel is missing its components.

Given that Reprise and JavaFXPad work, the weight is on the side of flicking the switch.

Regression test added for 501.
691 now working so moved out of currently-failing.

2376 annotated / raw | Diffs: previous, other | Lines: 209 ( +43, -15 )

Created: 2008-04-02 19:56:20 -0700 (9 months ago) | Author: rfield | Changeset: 2376

Coded but disabled JFXC-865 : Binding Overhaul: only generate bound functions when 'bound'
Coded but disabled JFXC-863 : Binding Overhaul: JavafxMethodSymbol needs isBound

Single function implementation and clean bound function semantics (see status email).

Also...
    Fixed JFXC-638 : Unable to change the value of a sequence element inside a function
    which is fixed as a side-effect of some generics work needed in the above.

Disabled because of HBox (and possibly other) update issues.
Primarily disabled by virtue of the switch JavafxDefs.useCorrectBoundFunctionSemantics
however, the PointerFactory classes have hard-coded changes -- see comments therein.

2365 annotated / raw | Diffs: previous, other | Lines: 181 ( +6, -0 )

Created: 2008-04-02 00:19:30 -0700 (9 months ago) | Author: bothner | Changeset: 2365

Syntactic sugar for animation:
 VAR => [bind] END_VALUE [tween [bind] INTERPOLATOR]
as syntactic sugar for
 javafx.animation.KeyValue { target: VAR_POINTER; value: [bind] END_VALUE;
     [ interpolate: [bind] INTERPOLATOR] }
No need to use PointerFactory any more (when using javafx.animation).

2270 annotated / raw | Diffs: previous, other | Lines: 175 ( +4, -0 )

Created: 2008-03-24 08:34:43 -0700 (9 months ago) | Author: bothner | Changeset: 2270

In JavafxCheck and JavafxClassReader use new array variableClassName
in JavafxDefs, instead of variableNCT in JavafxTypeMorpher.  This
allows us to remove the dependency in JavafxCheck and
JavafxClassReader of JavafxTypeMorpher.  And that avoids a messy
circularity when initializing javafcdoc (to follow).

Tags: 2008-03-31

2206 annotated / raw | Diffs: previous, other | Lines: 171 ( +4, -0 )

Created: 2008-03-17 17:20:47 -0700 (9 months ago) | Author: bothner | Changeset: 2206

New class file reader.  Instead of reading class files and then munging
the signatures on-the-fly, this one doesn't read any class files directly.
Instead it delegates to the javac ClassReader (the same one used by
the post-JavafxToJava-backend), and then maps javac Types and Symbol
to their JavaFX equivalents.  This should hopefully make classfile-reading
more robust, more efficient (since we only read each class file once),
and potentially allows compiler simplification (since the difference
between a class from the parser and the classfile-reader can be reduced).

Tags: 2008-03-24

2077 annotated / raw | Diffs: previous, other | Lines: 167 ( +3, -0 )

Created: 2008-03-07 20:31:40 -0800 (10 months ago) | Author: rfield | Changeset: 2077

Initial work on JFXC-837 : Binding Overhaul: compiler support for bound function call
Note: this is disabled, like all the new bind work, pending the completion of the decomposition-based bind architecture.

And clean-up of non-bound code in the process.

Tags: 2008-03-10 2008-03-17

1901 annotated / raw | Diffs: previous, other | Lines: 164 ( +0, -3 )

Created: 2008-02-22 18:57:36 -0800 (10 months ago) | Author: bothner | Changeset: 1901

Remove per-object attributes$ field - it was only used locally
to initialize$ anyway.
Also make some positions more specific.

Branch point for: tag:2008-02-25

Tags: weekly-2008-02-25 2008-02-25 M2 2008-03-03

1847 annotated / raw | Diffs: previous, other | Lines: 167 ( +2, -1 )

Created: 2008-02-21 05:08:46 -0800 (10 months ago) | Author: michael_heinrichs | Changeset: 1847

Small refactorings to fix warnings from FindBugs.

1779 annotated / raw | Diffs: previous, other | Lines: 166 ( +3, -2 )

Created: 2008-02-17 17:47:34 -0800 (10 months ago) | Author: rfield | Changeset: 1779

Groundwork for JFXC-710 : Compiler support for 'override attribute' to enable defaults on superclass attributes

Tags: weekly-2008-02-18

1776 annotated / raw | Diffs: previous, other | Lines: 165 ( +34, -3 )

Created: 2008-02-17 10:10:46 -0800 (10 months ago) | Author: briangoetz | Changeset: 1776

Merge in initialization branch.  Only downside is that classes cannot provide a default for superclass attributes (yet).  Robert is working on that now.

1685 annotated / raw | Diffs: previous, other | Lines: 134 ( +5, -5 )

Created: 2008-02-14 08:59:15 -0800 (10 months ago) | Author: michael_heinrichs | Changeset: 1685

Small refactorings to fix warnings from FindBugs.

1619 annotated / raw | Diffs: previous, other | Lines: 134 ( +2, -0 )

Created: 2008-02-08 11:51:58 -0800 (10 months ago) | Author: bothner | Changeset: 1619

Implementattion of the "easy" cases of bind of for comprehension.
(Somewhat kludgy - will get cleaner. as it is generalized.)

Branch point for: tag:weekly-2008-02-11

Tags: weekly-2008-02-11

1533 annotated / raw | Diffs: previous, other | Lines: 132 ( +3, -0 )

Created: 2008-01-28 22:15:21 -0800 (11 months ago) | Author: rfield | Changeset: 1533

Partial JFXC-613 : exclusive and open slices

Branch point for: brian-initialization-overhaul tag:weekly-2008-02-04

Tags: weekly-2008-02-04

1422 annotated / raw | Diffs: previous, other | Lines: 129 ( +0, -3 )

Created: 2008-01-17 12:37:38 -0800 (11 months ago) | Author: briangoetz | Changeset: 1422

Simplification of Location classes; create type-specific change triggers that pass the new and old values directly, rather than relying on possibly out-of-date getValue() / getPreviousValue() calls.  Ensure that triggers fire when values are set via object literals (though in a somewhat hackish and temporary way), fixes JFXC-519.

Tags: weekly-2008-04-21

1410 annotated / raw | Diffs: previous, other | Lines: 132 ( +4, -0 )

Created: 2008-01-16 22:36:54 -0800 (11 months ago) | Author: bothner | Changeset: 1410

Implement (compiler part of) support for sequence slices.

1376 annotated / raw | Diffs: previous, other | Lines: 128 ( +14, -7 )

Created: 2008-01-14 21:45:20 -0800 (11 months ago) | Author: briangoetz | Changeset: 1376

Copied to: branches/antlr-update/trunk/src/share/classes/com/sun/tools/javafx/comp/JavafxDefs.java 1391

Rename XxxLocation get/set/getPrevious methods to getAsXxx, to faciliate type system changes

Branch point for: reprise

1358 annotated / raw | Diffs: previous, other | Lines: 121 ( +1, -0 )

Created: 2008-01-10 21:33:27 -0800 (11 months ago) | Author: tball | Changeset: 1358

Implemented EventDispatchThread startup for UI runtime library.

Tags: weekly-2008-01-14

1272 annotated / raw | Diffs: previous, other | Lines: 120 ( +2, -0 )

Created: 2007-12-27 14:05:17 -0800 (12 months ago) | Author: briangoetz | Changeset: 1272

JFXC-392 -- postinit blocks.  The init block is called while the object is being initialized; it is suitable for vetoing or correcting values provided by the object literal, but not for acutally using the object (such as registering listeners.)  The postinit block (same syntax, just introduced with "postinit" instead of "init") is called after the object is already constructed and is suitable for actually using the newly created object.

1225 annotated / raw | Diffs: previous, other | Lines: 118 ( +2, -0 )

Created: 2007-12-20 23:03:38 -0800 (12 months ago) | Author: lubomirlitchev | Changeset: 1225

Fixed JFXC-465:Cannot access for var when used in init block.

1143 annotated / raw | Diffs: previous, other | Lines: 116 ( +2, -0 )

Created: 2007-12-11 08:15:16 -0800 (12 months ago) | Author: rfield | Changeset: 1143

Copied to: branches/new-hash-syntax/trunk/src/share/classes/com/sun/tools/javafx/comp/JavafxDefs.java 1217

Extend fix for JFXC-351 : == should use 'equals()'
Handle == in the face of arbitrary combinations of sequences Strings null-literal null-values Objects primitives

Branch point for: new-hash-syntax

1107 annotated / raw | Diffs: previous, other | Lines: 114 ( +0, -3 )

Created: 2007-12-06 23:14:09 -0800 (13 months ago) | Author: bothner | Changeset: 1107

No longer need "makeLazy" name.

1103 annotated / raw | Diffs: previous, other | Lines: 117 ( +3, -1 )

Created: 2007-12-06 21:14:13 -0800 (13 months ago) | Author: bothner | Changeset: 1103

The compiler no longer creates the extra XxxBindingExpression classes.
Instead it creates computeValue methods in XxxExpression.
(More run-time cleanun to follow.)

1034 annotated / raw | Diffs: previous, other | Lines: 115 ( +5, -1 )

Created: 2007-12-04 09:48:06 -0800 (13 months ago) | Author: lubomirlitchev | Changeset: 1034

Fixed:
JFXC-309 -- Cannot resolve an overloaded method returning float in Annon inner class
JFXC-341  -- Problems with signature clashes in overloaded bound functions

Tags: M1

973 annotated / raw | Diffs: previous, other | Lines: 111 ( +11, -3 )

Created: 2007-11-30 19:53:15 -0800 (13 months ago) | Author: rfield | Changeset: 973

Partial JFXC-330 : Gracefully handle dereference of null
Hack until we have optional types specified: dereference of null returns default value for the return type of the function
Dereference of null in function call -- enabled.
Regression test for this case.
Dereference of null in attribute access, not implemented.




966 annotated / raw | Diffs: previous, other | Lines: 103 ( +4, -0 )

Created: 2007-11-29 21:01:35 -0800 (13 months ago) | Author: rfield | Changeset: 966

Fix part B JFXC-324 : NPE and wrong results: dependencies for x.y need to be computed dynamically
Handle bi-direction bind.

965 annotated / raw | Diffs: previous, other | Lines: 99 ( +9, -0 )

Created: 2007-11-29 15:36:09 -0800 (13 months ago) | Author: rfield | Changeset: 965

Fix JFXC-324 : NPE and wrong results: dependencies for x.y need to be computed dynamically
Selects (x.y) are now added dynamically as dependents.
With regression test.
Thanks Brian for the quick runtime work.

Note: NPE will still occur with unset attribute references, but this is because of the second cause: the update

946 annotated / raw | Diffs: previous, other | Lines: 90 ( +1, -0 )

Created: 2007-11-27 16:32:43 -0800 (13 months ago) | Author: rfield | Changeset: 946

Fixed JFXC-312 : Wrong static class referenced in dispatch method
The MI mechanism is, in part, to create dispatch methods to the actual implementation method, which is a static method on a superclass.
Processing of source classes and processing of classes from class files are quite different.  Source file processing was fine.
However, class file processing was unable to see superclasses below the first enclountered class file class.
And changing that, there was no mechanism to destinguish, true implementation from dispatch methods, or abstract, or static, etc depending if the interface or class is used.
For now, I have marked actual implementation with "$impl" so that the correct dispatch methods can be built.
This isn't the right solution.  The right solution is probably to have meta information on the interface.

Using the javafxballs ant file, I get and internal error.  But I don't get this on a direct compile.  So, given timing, I'm committing.

918 annotated / raw | Diffs: previous, other | Lines: 89 ( +6, -0 )

Created: 2007-11-25 19:36:17 -0800 (13 months ago) | Author: rfield | Changeset: 918

Partial JFXC-265 : Permeate binding into bound function implementation
Convert LHS state to the new uniform state model.

Also, remove:      warning: not implemented --  dependency not generated
Underlying bug is still there.

Testng is broken for me, I will repair any bugs seen by Hudson.

865 new annotated / raw | Lines: 83 ( +83, -0 )

Created: 2007-11-23 16:04:44 -0800 (13 months ago) | Author: rfield | Changeset: 865

Fix JFXC-295 : false error on abstract function not having bound implementation at time of JavafxAttr
To fix this, and consistent with the general approach of having JavafxClassReader revert the class to a Java-esque state, bound functions are now ignored in class reading.

Re-enable JFXC-128 : Generate bound function bodies in concrete implementation classes
With the fix to the above, this can be re-enabled.

Start JFXC-297 : Internal: Move shared definitions (static strings, Names, etc) into JavafxDefs
It finally reached the to-painful-to-leave-it state.  
Moved core shared definitions into JavafxDefs.
PLEASE define all new shared definitions and definitions which become shared, in this file.


Crucible: Open Source License registered to Atlassian.
Atlassian Crucible, painless code review. (Version:1.6.1 Build:build-r20568 2008-09-30) - Administration - Page generated 2009-01-07 19:37 -0800